Hi,
I have a couple of suggestions to improve you Unix scripts:
1) yjp.sh
If YJP_JAVA_HOME is not set, the result is to pick up /bin/java.
That's not good enough (since I have JAVA_HOME set).
So please test "$YJP_JAVA_HOME" != "":
if [ "$YJP_JAVA_HOME" != "" ] ; then
JAVA_EXE=$YJP_JAVA_HOME/bin/java
fi
2) Tomcat, the modified startup_with_yjp.sh script:
Since you elect to expand YJP to 'YourKit Java Profiler 4.5 EAP build 602.app',
that will require quotes in all places which set shell variables:
_YH_="/tmp/YourKit Java Profiler 4.5 EAP build 602.app"
and subsequently in all places where _YH_ is being used.
EAP 602: scripting problems
-
- Posts: 6172
- Joined: Wed Aug 11, 2004 8:37 am
I'm sorry, I'm afraid I do not understand what's wrong.1) yjp.sh
If YJP_JAVA_HOME is not set, the result is to pick up /bin/java.
That's not good enough (since I have JAVA_HOME set).
So please test "$YJP_JAVA_HOME" != "":
if [ "$YJP_JAVA_HOME" != "" ] ; then
JAVA_EXE=$YJP_JAVA_HOME/bin/java
fi
The script yjp.sh actually probes YJP_JAVA_HOME, then JAVA_HOME, and only then java in PATH.
So if you have JAVA_HOME specified, it should be used.
Corrected in 606, thank you.2) Tomcat, the modified startup_with_yjp.sh script:
Since you elect to expand YJP to 'YourKit Java Profiler 4.5 EAP build 602.app',
that will require quotes in all places which set shell variables:
_YH_="/tmp/YourKit Java Profiler 4.5 EAP build 602.app"
and subsequently in all places where _YH_ is being used.
-
- Posts: 6172
- Joined: Wed Aug 11, 2004 8:37 am
-
- Posts: 6172
- Joined: Wed Aug 11, 2004 8:37 am